Deprecating sqlite object reinitialization

[erlendaasland (Erlend E. Aasland)]

I believe it is fully possible to verify that reinitialisation will work fine for sqlite3.Connection (and sqlite3.Cursor). There’s only a handful of methods in sqlite3.Cursor, and a dozen or so (from the top of my head) methods in sqlite3.Connection to audit.

IIRC, this is needed (given that connection __init__ is cleaned up a la GH-28227):

• all connection and cursor methods must check that they operate on a fully initialised object
• all connection and cursor methods must fail gracefully when the database pointer is NULL
• all cursor methods must fail gracefully when the statement pointer is NULL

IIRC, most of these conditions are already in place.

@steve.dower

I think the general concept of being able to re-call __init__ should work, and we should fix the segfault

@steve.dower

Without a really good reason to have them behave differently, we should keep them consistent so that both are easier to understand.

+1

@steve.dower

I still don’t think we should encourage it as a coding pattern

I totally agree