# Disable approving reviews of external contributors

**URL:** <https://discuss.python.org/t/disable-approving-reviews-of-external-contributors/1778>\
**Category:** Core Workflow\
**Created:** [May 31, 2019, 7:05am UTC](https://discuss.python.org/t/disable-approving-reviews-of-external-contributors/1778 "2019-05-31T07:05:20Z")\
**Posts on this page:** 1\
**Showing post:** 17

<div class="post-metadata">

**Author:** ![aeros](https://sea2.discourse-cdn.com/flex002/user_avatar/discuss.python.org/aeros/32/4140_2.png) [@aeros](https://discuss.python.org/u/aeros)\
**Post date:** [July 8, 2019, 8:49pm UTC](https://discuss.python.org/t/disable-approving-reviews-of-external-contributors/1778/17 "2019-07-08T20:49:44Z")

</div>

> [@jdemeyer](#):
>
> Why “non-core”? I don’t see a justification for making a difference between core devs are non-core devs here.

Specifically I just mean rejecting the non-core reviews who do not include any commentary in their feedback. Generally if a core developer approves without submitting direct feedback, they are saying “yes, this change is okay to merge” and providing the final stamp of approval. However, a new contributor doing so doesn’t accomplish too much. I’ve seen a few newer members of the community submitting the approve button without a word, and this doesn’t really make the process of making the final review any easier for the core devs (which seems to be the whole point of non-core reviews).

What Stefan said sums up the target audience (not every non-core dev review):

> [@skrah](#):
>
> This proposal (which I have already retracted earlier) was about relatively unknown people just clicking the approval button without saying anything further.

To make this less restrictive to contributors, my idea was to require some feedback (even it’s just a generic “Thanks for the contribution” message). If a non-core hit submit without any message, they would receive a message from the bot and the review wouldn’t go through.

---

_[View the full topic](https://discuss.python.org/t/disable-approving-reviews-of-external-contributors/1778)._
