Improve communication with contributors on the issue tracker and PRs (Language summit follow up)

I agree that improving communication is generally a good idea.

There are a few things we could tell to the contributor:

  • that we saw their issue/PR
    • this happens implicitly if someone triages the issue and/or comments
  • that the issue/PR is “valid”
    • this could happen implicitly (the issue has been triaged and not rejected)
    • or explicitly (a core dev commented approving the request)
  • that they need to do something
    • devs can request for more information/clarifications (possibly setting it as pending)
    • on PRs bots already ask for issue numbers, news entries, signing the CLA, etc.
    • on PRs reviewers and commenters can request for specific changes
  • that they already did everything they could
    • this can be done with a comment

If the contributor can’t do anything else, we can still tell them, but this only acknowledges that the contributor is now impotent, and the fate of the issue/PR is in our hands – it doesn’t solve the frustration of seeing their issue/PR sitting there.


This is what the stage field of BPO was used for, but we decided to drop it – see Map bpo issue metadata to GitHub fields/labels · Issue #5 · psf/gh-migration · GitHub :

To summarize:

  • The resolution s can be dropped (can be mentioned in the closing message)
  • The stage s can be dropped, since they can be inferred by other elements in the UI (linked PRs, requested reviews, backport labels, closed/merged issue/PR)

This doesn’t cover all cases though (see this flowcharts for other possible stages), so there could be some room for improvements.

There was also some discussion about stages starting in GitHub Issues Migration: label mapping - #12 by iritkatriel (and a number of other discussions/issues about close/pending that are a bit tangential for this topic).


Marking the issue as acknowledged is somewhat moot if no further action is then taken to resolve it.

The acknowledged label was also discussed here: Triaging/reviewing/fixing issues and PRs - #15 by ezio-melotti

acknowledged / accepted might also create expectations in the author, and has the disadvantage that most open issues will end up with an extra label. Searching for -label:acknowledge might also bring up old/triaged issues that are awaiting for more information, an expert opinion, or are still being discussed, making it more difficult to find untriaged issues.


This is an interesting observation. I wonder if it would be useful to generate a list of “active modules” based on the number of commits they received recently. This might be more effective than simply looking at modules that have a maintainer, and might find modules that don’t have a specific maintainer listed but still receive commits/reviews.


Usually I either just review it directly or assign it to me and come back to it later. A bot could tell the contributor that "Now <core-dev> is assigned to this issue/PR and is in charge of it.", but again it won’t make much difference if then the core dev takes a long time to reply.


On top of the ones you already mentioned, another option is to use reactions on the first message of the issue/PR such as :+1: and :-1: on the first message of the issue/PR. This could be used as as simple and less-spammy way of informing the OP that the issue/PR has been seen/acknowledged/accepted.

Another option is leveraging issue/PR templates to set expectations. They could say e.g. that

  • a :+1: from a core dev means that the issue/proposal is acknowledged/accepted
  • if there is anything they can do, they will be asked to do it
  • some parts of the code base are currently without a maintainer
  • sometimes it takes a long time for core devs to review/merge PRs

The templates could also link to the devguide and more information and suggestions (e.g. look at the git blame to find potential reviewers) can be listed there.

I think you’re missing my point about the bots treating acknowledged issues differently (this is also why it needs to be a formal marking, not just a comment from a core dev).

I was referring to marking the issue, before there is any PR.

You’re talking about “reactions” here, right? Is it possible to filter issues based on reactions?

You can sort by reactions and search by number of reactions (reactions:42), but I don’t believe you can filter by issues having a reaction from members of a particular GitHub team.

A

1 Like

If the goal is simply to mark issues in a way understandable by the bot, a :+1: reaction on the first message is a simple and non-intrusive way of doing that: the bot can access the reaction and reply accordingly.

If instead (or in addition), the goal is to find/filter issues that haven’t been acknowledged yet, then a label (or IMHO better – the lack thereof[1]) is probably a better solution. Humans can use it in searches, and the bot can write messages when the label is added/removed and then again after a prolonged silence, pinging either the OP or the core devs depending on the presence/absence of the label.


  1. a new/untriaged/unacknowledged label could be added automatically on new issues, and removed when the issue is acknowledged. ↩︎

2 Likes

I have done this on other repos and found it extremely useful for everyone involved; being able to tell at a glance based on a label why an issue is still open is really powerful (hence the needs labels on PRs :grin:).

If that includes triagers, then I think this is a good practice. On GitHub - microsoft/vscode-python: Python extension for Visual Studio Code we used to have a classify label added on all new issues, then we said “thanks” and added the appropriate needs label to signify it had been triaged and to say (we dropped the label as we start from triage-needed and getting the issue assigned is the next step).

3 Likes

I think “triaged” is not quite the same as “acknowledged”. For example: someone reports a bug in some stdlib module. A triager reproduces the bug and pings the relevant expert. Arguably the issue is now triaged, but the triager is not an expert on this lib and cannot say whether this is a bug or user’s misunderstanding of how the library should work on some edge case. So the bug report is not acknowledged yet.

I actually don’t think “triaged” is a boolean state, it’s an ongoing process.

I don’t know whether it’s better to add an “acknowledged” label or an “unacknowledged” label that gets added to all new issues and is later removed. I don’t know if it matters much which way (in both cases we have the question of how we acknowledge the current open issues).

We currently have an “invalid” label (I think we quickly close those issues, not sure why we need the label). How about we add a new “valid” label and then an issue can be “valid” or “invalid” or unlabelled. A core dev’s adding “valid” could be interpreted as “I think this should be done and I am likely to help review patches for this”.

4 Likes

I prefer the latter: add the label by default to new issues and have a triager remove it after looking at it. This has some advantages:

  • it’s easy to search for issues that need attention
  • it’s easier to remove the label than adding it
  • it doesn’t add an extra label to all open issues

A triager can decide to leave the label (or even add it back), if they are not confident about the status and/or validity of issue. For example, they can ping the expert and let them remove the label after assessing the validity of the issue, or add it back on an old issue that might no longer be valid.

2 Likes

Do we now stick “unacknowledged” on all open issues? Otherwise we won’t be able to distinguish between “acknowledged” and “created before July 2022”.

I would propose waiting-triager as less scary for first-time contributors.

I wrote above why I think triage is a different thing than acknowledgement, but I share your dislike of the negativity of “unacknowledged” for new issues.

My preference would be to have labels for “valid” and “invalid”, so that it is possible to have neither (the initial state). If nobody looked at the issue in enough detail to determine whether it is valid or not, then we don’t know and there is no need for a label.

Also, “valid” is much shorter than “acknowledged” so it will take less real estate on the issues view.

(The “invalid” label is less useful than “valid”, because “invalid” issues should just be closed, but we already have it so removing it is a different discussion).

To note, as a contributor I would also find it rather harsh-sounding, and is indeed now redundant now that GitHub introduced the ability to explicitly close issues as “not planned” (a much less harsh label than invalid, IMO), which are indicated by the color and symbol of the issue icon in the UI.

3 Likes

I created an issue on the core-workflow tracker to add “valid” and remove “invalid”. This particular proposal can be discussed there:

2 Likes

First we should reach an agreement on the goals and the semantics of this new label, then we can apply it accordingly. Most of the open issues are already triaged/acknowledged, so they won’t need the label. We could still add it to issues with no replies or that lack certain labels (e.g. type-*).

My goal was to make sure that all new issues get looked at by a triager and/or core dev. The untriaged label can be used to automatically mark these new issues, so that triagers can look for them. Triagers can decide to remove the label or ping the relevant experts and let them remove it.

That’s not the goal of the “acknowledged/valid” label, so can we discuss that on a different thread?

“looked at by a triager/core dev” or “has an expert-*” label is a much lower bar than what we are discussing for this new label.

There is some overlapping though: if the issue has been triaged and the untriaged label removed, it’s implicitly valid/accepted (otherwise it would have been closed).

I don’t think so. Most triage work doesn’t go as far as determining whether the issue is valid. For example, putting an “expert-asyncio” label just means the issue is related to asyncio. It doesn’t mean that the user didn’t misunderstand the output and reported a valid bug that needs to be fixed.

As I mentioned above, in that case the triagers should leave the label and let the experts remove it or close the issue. This was also discussed here: Triaging/reviewing/fixing issues and PRs - #15 by ezio-melotti (and in the following two messages).

It doesn’t make sense to me that a label is called “untriaged” and it’s the expert’s (not the triager’s) job to bring the issue to a state where the label can be removed.

I’m open to use a different name. Some previous bikesheddings included new, unclassified, classify [1], awaiting triage, needs triage, unacknowledged, waiting-triager.


  1. this is meant to indicate the next action that should be taken ↩︎