Lets make `zlib` required rather than optional to build CPython

Correct. I do propose to ignore that motivation, and replace it with:

1 Like

Embedding is a reasonable reason to want to exclude zlib, and Iā€™d argue more realistic than some hypothetical bootstrapping environment.

But Iā€™m okay with the default behaviour being to fail if you donā€™t have it, and require an explicit option to continue without. Perhaps itā€™s a good opportunity to ensure all references to it are in one place (presumably zlibmodule.c?) and that module is the only thing included/excluded. We ought to be able to relatively easily turn builtin modules on and off in very few locations.

1 Like

Itā€™s because I havenā€™t gotten around to setting everything up to do the static build from our source copies of zlib to then compile in the resulting .o file when building Python (i.e. WASI doesnā€™t have OS package maintainers building zlib for us, just me :wink:).

And Iā€™m fine not giving WASI an exemption once I have enough time to get zlib building via Tools/wasm/wasi.py.

1 Like