For code review or questions of meson-python, you’re also very welcome to ask at mesonbuild/meson-python · Discussions · GitHub. Now that it’s here, I’ll comment here though:
- Overall the
pyproject.tomllooks perfectly fine to me.- I assume you do not want to distribute wheels, because then indeed the
udunits2dependency is going to be a pain, and then you’d also have to useoldest-supported-numpyinstead ofnumpy>=1.20. For local builds and for conda packages, it looks fine as is.
- I assume you do not want to distribute wheels, because then indeed the
- The
meson.buildfile looks mostly fine, there are two potential issues:- The
incdir_numpything is a bit painful (I really need to makedependency('numpy')“just work”); if that starts failing on in-tree virtualenvs, use this instead. - It looks like you’re having a problem with dependency detection. You need either
pkg-configorcmakeinstalled as a build requirement, and ifudunits2does not come with the files needed forpkg-configorcmaketo detectudunits2then the detection will indeed fail (Meson won’t just go build and hope the right header is stumbled upon, likedistutilswould do). So what you then have to do is craft your own pkg-config file (and file a bug report againstudunits2ideally) - here is an example of how to do this: scipy-docs/blas-lapack.
- The