Permissions for the Python traige team

Recently, I became a member of the new Python triage team on GitHub. The majority of the permissions have been set correctly, but I think there’s some that may be missing (based on the devguide section):

  1. Ability to modify PR titles

Currently, I am unable to modify PR titles. Frequently, PR authors (especially those who are first-time contributors) will have a title that does not succinctly cover what the PR is addressing. Improving the title can help core devs find PRs in their respective areas of expertise and interest.

My alternative for now is to recommend for the author to adjust the title in the comments, but it would definitely be easier if we could directly edit PR titles. Most authors will eventually follow the recommendation in my experience (from before I became a triager), but there’s frequently a significant delay.

  1. Ability to assign organization members to PRs (Assignees).

As far as I’m aware, this was not a permission that was directly discussed. As a result, I’m not certain if it’s something that we should try to utilize productively, or if it’s simply an extra feature included with GitHub’s “Triage” permissions. For clarification, this is a permission we currently have that I wasn’t aware of.

If it’s something we should try to use productively, how should it be utilized? My first guess would be to use it for assigning the appropriate experts to PRs when they are not automatically added as reviewers from CODEOWNERS. However, “Assignees” looks to be more along the lines of something that should be used only for issues, not PRs. Assigning experts to review PRs seems like it would be done through the “Reviewers” list (which we don’t have permission to do, as intended). I figured it would be worthwhile to ask before trying to use it in any way.

These are definitely not critical concerns, and from what I can tell so far, everything else seems to be working as intended. I’m not even certain that it’s possible through GitHub to allow those with the “Triage” permission to edit PR titles. If it’s not possible, the devguide section should be updated accordingly.

Thanks @Mariatta for the proposal and for setting up the team! I think this team will definitely have a positive impact on the workflow, and free up the core devs to spend more time on merges/final reviews.

We don’t control what the triage permissions give you on GitHub, so there’s nothing here for us to do (our options are literally just “read”, “triage”, “write”, “maintain”, and “admin” for permissions and it’s only available for the entire repo).

Ah, I was hoping that wasn’t the case. It would be nice if GitHub allowed further customization of the permissions on a per-team basis, and more customization for different parts of the repository. In that situation, the existing 5 options would simply be templates to expand upon.

Since the “Triage” permission is in beta currently, perhaps the GitHub team will expand upon the existing permissions to include permissions such as editing PR titles. I’ll look into submitting feedback, but it might have a bit more weight if it comes from the organization rather than a single user.

We’re lucky to finally have “Triage” in beta since many have requested over the years.

I think gently requesting that folks update their title is a good approach

As for assigning organization members to PRs, I would put that on a shelf for the short term. Personally, I would love to see momentum pick up and get into a good workflow groove (thanks Mariatta) first before we add complexity. :wink:

I would be really, really happy if each new PR gets a welcoming response within 48 hours (but that’s just my dream not a formal target).

2 Likes

Good point. Since the team was just recently created, it makes sense to wait a decent amount of time before adding on additional responsibilities. I may have been jumping ahead a little bit. (:

This would still be a great goal to move towards! A simple “Thanks for the PR @username”, applying a few labels, and a preliminary/surface-level review (typos, title suggestions, etc) can be quite impactful. I’ll definitely try my best to prioritize PRs that haven’t received any responses.

2 Likes