jmroot
February 27, 2023, 2:26am
1
python:main ← jmroot:static_assert
opened 03:47AM - 12 Jul 22 UTC
Several platforms don't define the static_assert macro despite having
compiler … support for the _Static_assert keyword. The macro needs to be
defined since it is used unconditionally in the Python code. So it
should always be safe to define it if undefined and not in C++11 (or
later) mode.
Hence, remove the checks for particular platforms or libc versions,
and just define static_assert anytime it needs to be defined but isn't.
That way, all platforms that need the fix will get it, regardless of
whether someone specifically thought of them.
Also document that certain macOS versions are among the platforms that
need this.
* Issue: gh-91731
* Issue: gh-99069
Requesting a review of this PR here, since all previous review comments have been addressed and the latest changes have been awaiting review since December, and the issue was pinged a week ago with no response.