Pre-PEP discussion: revival of PEP 543 - A Unified TLS API for Python

[Julien00859 (Julien Castiaux)]

@jvdprng

@Julien00859

The same goes for ClientCertificate.truststore, it is set None by default at the moment, making the connection insecure by default. It should be a mandatory parameter client-side. Users who wish for an insecure connection are free to explicitly set the param None.

The backends are supposed to interpret a None trust store as the default (system) trust store. I am not sure if it would really make the connection insecure by default, as a missing trust store means all servers should be rejected. In order to skip the server certificate check, the user has to use the insecure module.

It is a nasty surprise that truststore=None means “use the system trust store” client-side and “disable client authentication” server-side, nothing is written in that regard in the PEP, only in the docstrings of tlslib. It means that client-side setting truststore=None and truststore=TrustStore.system() are two ways to achieve the same thing. IMO the default value should be the latter, and None not supported.

I assumed truststore=None to mean “disable server authentication”. I am now reading about the insecure section, I understand the will to make it extra difficult to instantiate an insecure configuration by accident.