"community guidelines" link doesn't work

Stefan2 · June 5, 2024, 3:37pm

When I click the flag icon under a post, a dialog pops up and the “our community guidelines” link doesn’t work. Tapping it doesn’t do anything, and when I open it in another tab, I get a “400 Bad Request” error page. Example URL: https://discuss.python.org/t/my-code-as-a-for-loop-that-dont-work/%{base_path}/guidelines

Stefan2 · July 8, 2024, 3:02pm

Still doesn’t work…

Stefan2 · July 25, 2024, 12:45pm

Does nobody in charge care? @moderators

pf_moore · July 25, 2024, 12:58pm

It works fine for me.

Stefan2 · July 25, 2024, 12:59pm

What’s the link’s URL for you?

effigies · July 25, 2024, 1:06pm

I get: https://discuss.python.org/guidelines

Stefan2 · July 25, 2024, 1:16pm

Ah, it seems to be a mobile-view-only problem. With that, still nothing happens when I click and the URL is for example:

https://discuss.python.org/t/community-guidelines-link-doesnt-work/55029/%{base_path}/guidelines

When I tell my browser to use desktop mode, it works and the URL is:

https://discuss.python.org/guidelines

malemburg · July 25, 2024, 1:17pm

You may have NoScript or some other privacy filter running preventing the JavaScript templating from working correctly. It does work fine for me in Brave.

effigies · July 25, 2024, 1:21pm

Using Firefox for Android, I see:

Stefan2 · July 25, 2024, 1:27pm

I didn’t install/configure anything like NoScript, and I don’t think something like that was pre-installed (I’m using the Chrome browser on a Google Pixel 6a bought from the Google store).

jeanas · July 25, 2024, 1:28pm

I have the same problem with Firefox on iOS (link is broken, but switching to desktop mode fixes it). The problem also reproduces with Safari on iOS (unsurprising since it’s the same browser engine). I do not have JavaScript disabled (Discourse wouldn’t work at all anyway) nor any particular ad blocker / user scripts / anything.

effigies · July 25, 2024, 1:41pm

FWIW it’s reproducible in developer mode on Firefox 128.0 on Ubuntu 22.04 by selecting an Android UA:

I don’t see this issue on another instance I moderate, but that is running an older version of Discourse. I don’t know if I have flagging permissions on any other discourses to see if it reproduces elsewhere.

malemburg · July 25, 2024, 1:48pm

Discourse seems to use different text templates for mobile vs. desktop. Only the mobile version includes the “%{base_path}” prefix. The desktop version doesn’t. Probably something the @admins can fix, unless it’s hardwired into Discourse.

jeanas · July 25, 2024, 2:00pm

I just looked into the settings on another Discourse forum where I’m an admin. it looks like the template used on desktop is topic_flag_types.inappropriate.description while the one on mobile is topic_flag_types.inappropriate.short_description.

effigies · July 25, 2024, 2:03pm

Both currently contain the template:

github.com

discourse/discourse/blob/40bc0bcf98da9f3608f2d747a1ba43c5286c307f/config/locales/server.en.yml#L1078-L1081


      
          inappropriate:
            title: "Inappropriate"
            description: 'This post contains content that a reasonable person would consider offensive, abusive, to be hateful conduct or a violation of <a href="%{base_path}/guidelines">our community guidelines</a>.'
            short_description: 'A violation of <a href="%{base_path}/guidelines">our community guidelines</a>'

Seems like a bug in some versions of Discourse to not interpolate for mobile.

devdanzin · July 25, 2024, 2:07pm

Seems like it was reported, but no follow up came from it:

davidism · July 25, 2024, 3:30pm

I’ve modified the strings to not use the interpolation for now.

malemburg · July 26, 2024, 10:20am

I can confirm that it’s working now. Thanks.