First PR, appreciate some advice

Hi,
I’ve opened a PR gh-109945: Enable spec of multiple curves/groups for TLS by planetf1 · Pull Request #119244 · python/cpython · GitHub which is a proposed change for TLS support - to allow multiple curves.

Not being familiar with the codebase I’d really appreciate some feedback on questions I have about error handling

2 Likes

Any takers? I have a question about error handling, and would like to ensure I propose a fix which is most ameniable to the core team.

I’ll take a look in the next week or so, I’m on vacation right now.

Many thanks for offering. I have hopefully made the PR a little better now (tests, doc)but remain a little unsure on the error handling, and whether one of the existing error functions is thread safe.