Request for review "gh-107545: Fix misleading setsockopt error message"

naweiss · July 7, 2025, 11:34am

I have a pull requests that I opened 2 years ago that could use a core review.

github.com/python/cpython

gh-107545: Fix misleading setsockopt error message

main ← naweiss:fix-issue-107545

opened 07:09PM - 01 Aug 23 UTC

naweiss

+33 -0

According to Python's documentation, `setsockopt` can get either `int`, `buffer`… or `None` as the third argument. The way it is currently implemented is by trying to parse all of the three arguments as ints, if this fails **no matter what the reason is** we just try the next overload. Since `2**31` causes `PyExc_OverflowError` we try the next overloads. Because the `buffer` overload is last we get type error for the third argument instead of `OverflowError` (e.g. `TypeError: a bytes-like object is required, not 'int'`). * Issue: gh-107545

It solves a minor issue with error reporting for socket.setsockopt as demonstrated in: https://github.com/python/cpython/issues/107545