Request of feedback for a PR at an operational/procedure level

Hey all!

I created a quite simple PR (a couple of docstrings improvement) that I think it’s ready to merge.

However, as it was a while since my last not-trivial commit, I’d love some feedback on which is the procedure. Shall I just merge it? Do I need to do something else before? What about backporting (I remember there is some bot but don’t know how to use/trigger it)? Etc.

Thanks!

Hello!

Reviews are required for features, but are still useful on everything else. It is okay to merge trivial things without review, but I’d wait a little while for a review if it’s not urgent.

It’s good to backport docs changes to bugfix branches, especially to the branch whose docs are at 3.14.3 Documentation – we don’t need to wait until the next feature release to put docs improvements in front of our readers.

To backport, add the relevant “needs backport to 3.x” labels (I recommend to 3.13 and 3.14) and the bot will attempt to backport. It will tell you if it can’t do it, usually because of a conflict, and will give you the commands to do it manually.

1 Like

And correcting myself here, your PR is a docstring change, not regular docs, so the docs website is irrelevant. But I still recommend backporting to put docs improvements in front of our readers sooner.

1 Like

Thanks! Will do.

1 Like