Hello, can I please get a review here? gh-157581: can_colorize should handle unexpected exceptions by edvilme · Pull Request #157590 · python/cpython
It catches unhandled exceptions in can_colorize to avoid overflowing the terminal window with errors if they arise during verification.
From the devguide:
If your pull request has not received any notice from reviewers (that is, no comment made) after one month, first “ping” the issue on the issue tracker to remind the subscribers that the pull request needs a review. If you don’t get a response within a week after pinging the issue, you can post on the Core Development Discourse category to ask for someone to review your pull request.
You have not done the first step, nor has it been one month.
The first step doesn’t make sense when the only subscribers are the OP and the PR’s author. So asking for a request on DPO is fine. As for a month, it’s been 2 weeks and I think we would have totally missed the PR and issue so it’s fine.
Maybe I’m mistaken, but I thought the subscribers included to people watching the cpython repo?
Oh right, I forgot. I always forget about people subscribed through email. But I don’t think lots of maintainers have subscribed to it because the trafic is way too large. Anyway I posted a review.
Yes I don’t want to be annoying and usually try to wait for a couple of days before pinging someone or posting here. Thanks for the reviews (here and in the other PRs)
Update: addressed feedback, thanks a lot!