PR #151970 has been awaiting review for over a month. It fixes executable permission handling in zipapp, and all CI checks are passing. A review would be appreciated: gh-96867: Set zipapp execute bits from readable bits by yuanx749 · Pull Request #151970 · python/cpython · GitHub
I’ll take a look at the PR and review it. I’m not sure why I didn’t get flagged on the PR as code owner.
It looks like zipapp isn’t currently included in the CODEOWNERS file
What a weird und unfriendly question. The issue that this is addressing is clearly linked in the PR and nobody needs permission to contribute to Python. If there are any issues with a PR these can be discussed in a friendly and respectful manner, but I honestly don’t appreciate the dismissive tone in your post for someone to someone who had a good faith contribution.
9 Likes
I’ll take that on board Sebastian.
1 Like
Agreed. My “like” of James’ comment was with regard to his point that the low-level bit manipulation in the patch seemed over-complex, but I agree that no-one needs to “give the OK” for a contribution.
I have reviewed the PR, and for the record here I’m unhappy with trying to implement a robust “make a file executable” function in zipapp. If this is useful functionality, then IMO it should be a public function in the os or pathlib module, which zipapp can then just use.
If you follow the link back to the issue, that in turn has a link back to the original discussion when the “make the zipapp executable” functionality was added. There is a suggested implementation there, which is not the same as the one in this PR. I’m not sufficiently knowledgeable with regard to Unix permissions to be able to make a judgement as to which approach is better - another reason I’d prefer this to be maintained in a module where people who do have such expertise will support it.
1 Like