Support for deprecating global members produced by enum.EnumMeta._convert_

graingert · July 21, 2022, 3:21pm

The ssl module is currently removing a number of deprecated module global enum flags

when a module global is deprecated a module level __getattr__ is used to raise a DeprecationWarning eg

python/cpython/blob/6dadf6ca019f2e19ca8f0344903be0c539263c30/Lib/importlib/abc.py#L28-L38


      
          def __getattr__(name):
              """
              For backwards compatibility, continue to make names
              from _resources_abc available through this module. #93963
              """
              if name in _resources_abc.__all__:
                  obj = getattr(_resources_abc, name)
                  warnings._deprecated(f"{__name__}.{name}", remove=(3, 14))
                  globals()[name] = obj
                  return obj
              raise AttributeError(f'module {__name__!r} has no attribute {name!r}')

However this wasn’t done for ssl because this is not ergonomic when using enum.EnumMeta._convert_ as the only workaround is ugly: using del to delete the global and add it back as deprecated

github.com/python/cpython

gh-94598: Remove deprecated ssl modules features

python:main ← tiran:py312_ssl_removal

opened 09:28AM - 06 Jul 22 UTC

tiran

+186 -7162

* Issue: gh-94598

And so it’s now difficult to know as a downstream consumer of ssl if my project accesses these flags even if it doesn’t pass them to ssl.SSLContext